fix: rewrite citation formatters — Bluebook, APA, JAMA #308
2 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
kert
|
c0ddf54c31
|
fix: rekey 10,236 invalid bib.sqlite keys to Zotero charset, convert CCLF cites
Some checks failed
CI / lint-test (push) Failing after 1m25s
CI / skinny-install (aco) (push) Successful in 52s
CI / skinny-install (api) (push) Successful in 27s
CI / skinny-install (bcda) (push) Successful in 36s
CI / skinny-install (bib) (push) Successful in 36s
CI / skinny-install (bls) (push) Successful in 28s
CI / skinny-install (ccw) (push) Successful in 31s
CI / skinny-install (cms) (push) Successful in 27s
CI / skinny-install (cli) (push) Successful in 36s
CI / skinny-install (conf) (push) Successful in 30s
CI / skinny-install (api) (pull_request) Successful in 32s
CI / skinny-install (bcda) (pull_request) Successful in 34s
CI / skinny-install (bls) (pull_request) Successful in 29s
CI / skinny-install (bib) (pull_request) Successful in 42s
CI / skinny-install (ccw) (pull_request) Successful in 29s
CI / skinny-install (opps) (push) Successful in 30s
CI / skinny-install (perf) (push) Successful in 32s
CI / skinny-install (pfs) (push) Successful in 34s
CI / skinny-install (rex) (push) Successful in 33s
CI / lint-test (pull_request) Failing after 1m22s
CI / skinny-install (aco) (pull_request) Successful in 1m1s
CI / skinny-install (cli) (pull_request) Successful in 32s
CI / skinny-install (cms) (pull_request) Successful in 30s
CI / skinny-install (conf) (pull_request) Successful in 30s
CI / skinny-install (rex) (pull_request) Successful in 26s
Infra CI / zotero (push) Successful in 6s
Infra CI / mc (push) Successful in 6s
Infra CI / notebooks (pull_request) Successful in 6s
Infra CI / zotero (pull_request) Successful in 6s
Infra CI / docs (pull_request) Failing after 6s
CI / skinny-install (opps) (pull_request) Successful in 26s
CI / skinny-install (perf) (pull_request) Successful in 33s
CI / skinny-install (pfs) (pull_request) Successful in 27s
Infra CI / notebooks (push) Successful in 7s
Infra CI / docs (push) Failing after 8s
Infra CI / api (push) Successful in 8s
Infra CI / api (pull_request) Successful in 9s
Infra CI / mc (pull_request) Successful in 7s
Two changes:
1. Rekeyed all bib.sqlite items/attachments with chars outside the
Zotero charset (23456789ABCDEFGHIJKLMNPQRSTUVWXYZ). Chars 0, 1, O, L
are not valid in Zotero keys. 10,236 items + 1,881 attachments fixed.
2. Converted all 30 CCLF IP Section freeform citations in
aco/express/cclf.py to structured :pincite: directives:
Before: CCLF IP Section 3.1 "Matching MBIs" (p.14):
After: :pincite:`VTWVB384 §3.1 p.14` — Matching MBIs:
Updated tests to verify pincite parsing instead of meta: tag extraction
from the now-converted docstrings.
fixes #302
|
||
|
kert
|
7db84dce62
|
fix: rewrite citation formatters — Bluebook, APA, JAMA with proper FR format
Some checks failed
CI / lint-test (pull_request) Failing after 1m20s
CI / skinny-install (api) (pull_request) Successful in 28s
CI / skinny-install (bib) (pull_request) Successful in 32s
CI / skinny-install (bcda) (pull_request) Successful in 35s
CI / skinny-install (bls) (pull_request) Successful in 36s
CI / skinny-install (ccw) (pull_request) Successful in 36s
CI / skinny-install (cms) (pull_request) Successful in 29s
CI / skinny-install (cli) (pull_request) Successful in 38s
CI / skinny-install (conf) (pull_request) Successful in 29s
CI / skinny-install (opps) (pull_request) Successful in 32s
CI / skinny-install (perf) (pull_request) Successful in 28s
CI / skinny-install (pfs) (pull_request) Successful in 29s
CI / skinny-install (aco) (pull_request) Successful in 50s
Infra CI / notebooks (pull_request) Successful in 6s
Infra CI / zotero (pull_request) Successful in 6s
CI / skinny-install (rex) (pull_request) Successful in 27s
Infra CI / docs (pull_request) Failing after 8s
Infra CI / api (pull_request) Successful in 8s
CI / skinny-install (aco) (push) Successful in 49s
CI / lint-test (push) Failing after 1m22s
CI / skinny-install (api) (push) Successful in 29s
CI / skinny-install (conf) (push) Successful in 31s
CI / skinny-install (opps) (push) Successful in 32s
CI / skinny-install (perf) (push) Successful in 41s
Infra CI / api (push) Successful in 6s
Infra CI / mc (push) Successful in 6s
Infra CI / mc (pull_request) Successful in 6s
CI / skinny-install (bcda) (push) Successful in 30s
CI / skinny-install (bib) (push) Successful in 34s
CI / skinny-install (bls) (push) Successful in 30s
CI / skinny-install (ccw) (push) Successful in 28s
CI / skinny-install (cli) (push) Successful in 28s
CI / skinny-install (cms) (push) Successful in 31s
CI / skinny-install (pfs) (push) Successful in 39s
Infra CI / notebooks (push) Successful in 7s
Infra CI / zotero (push) Successful in 6s
CI / skinny-install (rex) (push) Successful in 25s
Infra CI / docs (push) Failing after 6s
Replaces hacky hardcoded formatters with proper citation formatting following the Bluebook Law Review CSL conventions (Tierney 2026). Rules (Bluebook): Title, Volume Fed. Reg. Page (Month Day, Year). Before: CMS. (2025). Title. *Federal Register*, *90*, 98452. After: Title, 90 Fed. Reg. 98452 (Nov. 18, 2024). Manuals (Bluebook): Ctrs. for Medicare & Medicaid Servs., Manual Name, CMS Pub. Number, Ch. N (Year). Regulations: unchanged (already correct per Bluebook). Journal articles (new): APA: Author(s). (Year). Title. *Journal*. doi:DOI JAMA: Author(s). Title. *Journal*. Year. doi:DOI Auto-detected by doc_type=journal-article or PMID in extra field. Handles 1, 2, 3+ authors. Parses Authors/DOI/PMID/Journal from extra. Also: Bluebook date formatting with month abbreviations per Table T12, author parsing from extra field, DOI/PMID extraction. 35 tests (was 27), all passing. fixes #300, fixes #301, fixes #303 |