homelab/stack
1
0
Fork 0
Code Issues 70 Pull Requests 1 Actions Packages Projects 1 Releases Wiki Activity

pfs: align pfs.rvu_proposed column names with pfs.rvu (modifier/mod, nonfac_pe_rvu/non_fac_pe_rvu) #607

New Issue
Closed
opened 2026-08-13 20:20:59 +00:00 by kert · 2 comments
kert commented 2026-08-13 20:20:59 +00:00
Owner
Copy Link

P36 final review follow-up: pfs.rvu_proposed renamed columns relative to pfs.rvu (modifier vs mod, nonfac_pe_rvu vs non_fac_pe_rvu), a disclosed-but-costly deviation from the spec's 'same column shape' intent — every join (e.g. the CY2026 notebook SQL) pays alias juggling. Align names before more consumers accrete. Loader: src/pfs/nprm.py; consumers: notebooks/cy2026_pfs_proposed_rule.py.

P36 final review follow-up: pfs.rvu_proposed renamed columns relative to pfs.rvu (`modifier` vs `mod`, `nonfac_pe_rvu` vs `non_fac_pe_rvu`), a disclosed-but-costly deviation from the spec's 'same column shape' intent — every join (e.g. the CY2026 notebook SQL) pays alias juggling. Align names before more consumers accrete. Loader: [`src/pfs/nprm.py`](https://git.fhirworx.io/homelab/stack/src/branch/main/src/pfs/nprm.py); consumers: [`notebooks/cy2026_pfs_proposed_rule.py`](https://git.fhirworx.io/homelab/stack/src/branch/main/notebooks/cy2026_pfs_proposed_rule.py).
kert added the datapfs labels 2026-08-13 20:20:59 +00:00
kert added this to the P37: CY2027 PFS Proposed Rule — capture, ingest, APM analysis milestone 2026-08-13 20:36:15 +00:00
kert commented 2026-08-13 23:48:21 +00:00
Author
Owner
Copy Link

Implementation plan: docs/superpowers/plans/2026-08-13-cy2027-pfs-proposed-rule-p37.md — Task 1. Spec: docs/superpowers/specs/2026-08-13-cy2027-pfs-proposed-rule-design.md.

Implementation plan: [`docs/superpowers/plans/2026-08-13-cy2027-pfs-proposed-rule-p37.md`](https://git.fhirworx.io/homelab/stack/src/branch/main/docs/superpowers/plans/2026-08-13-cy2027-pfs-proposed-rule-p37.md) — Task 1. Spec: [`docs/superpowers/specs/2026-08-13-cy2027-pfs-proposed-rule-design.md`](https://git.fhirworx.io/homelab/stack/src/branch/main/docs/superpowers/specs/2026-08-13-cy2027-pfs-proposed-rule-design.md).
kert commented 2026-08-14 15:10:50 +00:00
Author
Owner
Copy Link

Merged to main in a75b4c7 (branch p37-cy2027-rule). Fixed in 810f7e2 + reloaded via 1c688be's schema-migration guard: src/pfs/nprm.py columns now byte-match pfs.rvu (mod, non_fac_pe_rvu, …), P36 notebook SQL simplified, live table recreated with aligned names.

Merged to main in a75b4c7 (branch p37-cy2027-rule). Fixed in 810f7e2 + reloaded via 1c688be's schema-migration guard: [`src/pfs/nprm.py`](https://git.fhirworx.io/homelab/stack/src/branch/main/src/pfs/nprm.py) columns now byte-match `pfs.rvu` (mod, non_fac_pe_rvu, …), P36 notebook SQL simplified, live table recreated with aligned names.
kert closed this issue 2026-08-14 15:10:50 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
REST API (FastAPI)
 auth
Authentication and authorization
 bib
Bibliography, Zotero, citations
 ci
CI/CD pipelines and Woodpecker plugins
 cli
CLI commands and UX
 cloud
Cloud provider abstraction (AWS, GCP, Azure, self-hosted)
 config
Configuration and wiring
 data
Data loading, CCLF, BCDA, seeds
 databricks
Databricks jobs and deployment
 docs
Documentation and generated references
 image:api
image:docs
image:mc
image:notebooks
image:zotero
infra
lakehouse
Nessie, Polaris, Trino, Iceberg
 llm
llm module — local RAG over comments + Zotero corpus
 notebooks
marimo notebook errors (auto-filed by nb-watcher/nb-integration)
 packaging
Python packaging, optional deps, build system
 pfs
pipeline
Pipeline execution and validation
 pipeline:ci
pipeline:deploy
pipeline:harden
pipeline:infra-ci
pipeline:rebuild-all
pipeline:release
qpp
quality
Testing, coverage, error handling
 step:build
step:deploy
step:hadolint
step:lint
step:publish
step:scan
step:test
step:validate
styles
Charts, figures, visual theming
 tree
Project directory structure and file organization
No Label data pfs
Milestone
No items
No Milestone P37: CY2027 PFS Proposed Rule — capture, ingest, APM analysis
Projects
Clear projects
No project
Assignees
Clear assignees
kert renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: homelab/stack#607
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?