P10: Nature figure standards — palette, Altair theme, DAG colors #49

Closed
kert wants to merge 0 commits from feature/nature-figure-standards into main
Owner

Summary

  • Add Nature Research figure guide citation to bib store (key 9ASETLJ4)
  • Create styles/nature.py — accessible 8-colour palette (Paul Tol bright), Altair theme, matplotlib rcParams, Cytoscape helpers
  • Retrofit all ~30 Altair charts in notebooks/acodb_explorer.py to use Nature theme
  • Update src/aco/dag.py to import shared palette from styles/nature.py

Nature specs implemented

  • Sans-serif (Helvetica/Arial), 5-7pt body, 8pt bold titles
  • No gridlines, axis lines + tick marks mandatory
  • Accessible colorblind-safe palette
  • RGB colour space, 450 DPI

Closes #45, closes #46, refs #47

Test plan

  • All 11,766 tests pass
  • ruff lint + format clean
  • marimo check passes
  • Visual review of charts in notebook
## Summary - Add Nature Research figure guide citation to bib store (key `9ASETLJ4`) - Create `styles/nature.py` — accessible 8-colour palette (Paul Tol bright), Altair theme, matplotlib rcParams, Cytoscape helpers - Retrofit all ~30 Altair charts in `notebooks/acodb_explorer.py` to use Nature theme - Update `src/aco/dag.py` to import shared palette from `styles/nature.py` ## Nature specs implemented - Sans-serif (Helvetica/Arial), 5-7pt body, 8pt bold titles - No gridlines, axis lines + tick marks mandatory - Accessible colorblind-safe palette - RGB colour space, 450 DPI Closes #45, closes #46, refs #47 ## Test plan - [x] All 11,766 tests pass - [x] ruff lint + format clean - [x] marimo check passes - [ ] Visual review of charts in notebook
kert added this to the P10: Figure Standards — Nature-conformant chart styling milestone 2026-03-21 17:57:59 +00:00
kert added 1 commit 2026-03-21 17:57:59 +00:00
add Nature figure standards: palette, Altair theme, DAG colors
Some checks failed
ci/woodpecker/push/ci Pipeline was successful
ci/woodpecker/pr/infra-ci Pipeline failed
ci/woodpecker/push/infra-ci Pipeline was successful
coverage 99% coverage
ci/woodpecker/pr/ci Pipeline was successful
33701365be
Create styles/nature.py with accessible 8-colour palette (Paul Tol
bright scheme), Altair theme registration, matplotlib rcParams, and
Cytoscape style helpers — all conforming to Nature Research figure
specifications (bib citation 9ASETLJ4).

Retrofit acodb_explorer.py: replace all hardcoded set2/hex colors
with PALETTE references, enable the Nature Altair theme on import.

Update src/aco/dag.py to import schema colors from the shared
styles/nature.py module instead of maintaining a separate Tableau 10
palette.

fix #45, fix #46, refs #47
kert added 1 commit 2026-03-21 18:08:05 +00:00
fix notebook runtime: add altair/pandas deps, fix table ref, fix sys.path
Some checks failed
ci/woodpecker/pr/infra-ci Pipeline failed
ci/woodpecker/push/infra-ci Pipeline was successful
ci/woodpecker/pr/ci Pipeline was successful
coverage 99% coverage
ci/woodpecker/push/ci Pipeline was successful
cfeb09eff4
- Add altair and pandas as dev dependencies so notebooks run as scripts
- Fix sys.path for styles/ to resolve relative to __file__, not CWD
- Fix broken table ref: chronic_conditions_long → cms_chronic_conditions_long
- Update pre-commit hook: lint only staged files, run notebooks as scripts

refs #45
kert closed this pull request 2026-03-21 18:38:15 +00:00
Some checks failed
ci/woodpecker/pr/infra-ci Pipeline failed
Required
Details
ci/woodpecker/push/infra-ci Pipeline was successful
Required
Details
ci/woodpecker/pr/ci Pipeline was successful
Required
Details
coverage 99% coverage
ci/woodpecker/push/ci Pipeline was successful
Required
Details

Pull request closed

Sign in to join this conversation.