kert 7281012c76 fix(comments): address code-review BLOCKER + 4 IMPORTANT issues ...

From the end-of-impl review:

1. BLOCKER: SQLite cross-thread error in stack comments extract --bib.
   _bib_lookup_factory was sharing the bib.connect() connection across
   walker worker threads — sqlite3 defaults to check_same_thread=True
   so every worker would have raised ProgrammingError. Tests didn't
   catch it because all CLI tests pass --no-bib. Fix: open a fresh
   read-only connection with check_same_thread=False directly via
   conf.path("db.bib"); SQLite handles concurrent reads safely.

2. view._iter_index_rows now catches yaml.YAMLError too, so one
   malformed combined.md doesn't crash `stack comments stats`.

3. Image attachments (.jpg/.png/.tif/.tiff/.gif/.bmp) now classify as
   ocr_needed instead of being silently dropped as unsupported. This
   gives the phase-2 OCR command a clean candidate set to query.
   Real CMS comments include scanned-letter images.

4. view.register() defaults to rebuild=True so downstream consumers
   (#254/#255) always see fresh data. Pass rebuild=False to skip.

5. extract_comment writes via tmp file + os.replace() so concurrent
   walkers / restarts never see a half-written combined.md.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-04-23 16:09:47 -04:00

1.4 KiB

Raw Blame History

View Raw