homelab/stack
1
0
Fork 0
Code Issues 133 Pull Requests 1 Actions Packages Projects 1 Releases Wiki Activity

ci: stale .git/hooks/pre-commit shadow copy misleads diagnosis — dev/hooks + sem.hooks are authoritative #599

New Issue
Closed
opened 2026-08-12 16:59:57 +00:00 by kert · 1 comment
kert commented 2026-08-12 16:59:57 +00:00
Owner
Copy Link

A pre-sem.hooks bash copy of the pre-commit hook survived in .git/hooks/pre-commit (untracked, from before core.hooksPath=dev/hooks). It is inert — git runs dev/hooks/pre-commit → python -m sem.hooks, which already scopes pytest to changed modules and runs -n auto — but reading the stale copy as "the hook" cost a debugging session two 15-minute serial full-suite runs today while chasing #598. Removed the stale copy from this clone. README (§Pre-commit hooks) already documents the correct setup; no repo change needed beyond awareness. If other clones exist, rm .git/hooks/pre-commit there too.

A pre-sem.hooks bash copy of the pre-commit hook survived in `.git/hooks/pre-commit` (untracked, from before core.hooksPath=dev/hooks). It is inert — git runs `dev/hooks/pre-commit` → `python -m sem.hooks`, which already scopes pytest to changed modules and runs `-n auto` — but reading the stale copy as "the hook" cost a debugging session two 15-minute serial full-suite runs today while chasing #598. Removed the stale copy from this clone. README (§Pre-commit hooks) already documents the correct setup; no repo change needed beyond awareness. If other clones exist, `rm .git/hooks/pre-commit` there too.
kert added the ciquality labels 2026-08-12 16:59:57 +00:00
kert commented 2026-08-12 16:59:57 +00:00
Author
Owner
Copy Link

Resolved in-clone: rm .git/hooks/pre-commit; verified git config core.hooksPath → dev/hooks and git rev-parse --git-path hooks → dev/hooks, so sem.hooks (scoped + -n auto, src/sem/hooks.py:312-320) is what actually gates commits. No tracked-file change required — closing.

Resolved in-clone: `rm .git/hooks/pre-commit`; verified `git config core.hooksPath` → `dev/hooks` and `git rev-parse --git-path hooks` → `dev/hooks`, so `sem.hooks` (scoped + `-n auto`, src/sem/hooks.py:312-320) is what actually gates commits. No tracked-file change required — closing.
kert closed this issue 2026-08-12 16:59:58 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
REST API (FastAPI)
 auth
Authentication and authorization
 bib
Bibliography, Zotero, citations
 ci
CI/CD pipelines and Woodpecker plugins
 cli
CLI commands and UX
 cloud
Cloud provider abstraction (AWS, GCP, Azure, self-hosted)
 config
Configuration and wiring
 data
Data loading, CCLF, BCDA, seeds
 databricks
Databricks jobs and deployment
 docs
Documentation and generated references
 image:api
image:docs
image:mc
image:notebooks
image:zotero
infra
lakehouse
Nessie, Polaris, Trino, Iceberg
 llm
llm module — local RAG over comments + Zotero corpus
 notebooks
marimo notebook errors (auto-filed by nb-watcher/nb-integration)
 packaging
Python packaging, optional deps, build system
 pfs
pipeline
Pipeline execution and validation
 pipeline:ci
pipeline:deploy
pipeline:harden
pipeline:infra-ci
pipeline:rebuild-all
pipeline:release
qpp
quality
Testing, coverage, error handling
 step:build
step:deploy
step:hadolint
step:lint
step:publish
step:scan
step:test
step:validate
styles
Charts, figures, visual theming
 tree
Project directory structure and file organization
No Label ci quality
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dom kert renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: homelab/stack#599
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?