Fix rebuild-all.yml: broken shell loop in push-images step #40

New Issue

kert · 2026-03-13T14:33:45Z

kert commented

2026-03-13 14:33:45 +00:00

Problem

The push-images step has a for loop split across YAML list items:

commands:
  - for SVC in notebooks zotero docs; do
  -   docker tag fhirworx/$SVC:$TAG ...
  - done

Each - is a separate command. The shell receives for ... do without done (syntax error), then standalone docker tag with undefined $SVC.

Also, rebuild-all.yml has no depends_on at all, so build/scan/push steps run in parallel — scans start before builds finish.

Fix

Use a YAML block scalar (|) for the loop and add proper depends_on ordering.

Acceptance criteria

Manual trigger of rebuild-all pipeline completes successfully
All three images are built, scanned, tagged, and pushed in correct order

## Problem The `push-images` step has a `for` loop split across YAML list items: ```yaml commands: - for SVC in notebooks zotero docs; do - docker tag fhirworx/$SVC:$TAG ... - done ``` Each `- ` is a separate command. The shell receives `for ... do` without `done` (syntax error), then standalone `docker tag` with undefined `$SVC`. Also, rebuild-all.yml has no `depends_on` at all, so build/scan/push steps run in parallel — scans start before builds finish. ## Fix Use a YAML block scalar (`|`) for the loop and add proper `depends_on` ordering. ## Acceptance criteria - Manual trigger of rebuild-all pipeline completes successfully - All three images are built, scanned, tagged, and pushed in correct order

kert added this to the P9: CI/CD Unification milestone 2026-03-13 14:33:45 +00:00

kert added the quality label 2026-03-13 14:33:45 +00:00

kert referenced this issue from a commit

2026-03-13 14:37:40 +00:00

P9 CI/CD unification: fix broken pipelines, harden deploy (fix #36, fix #37, fix #38, fix #39, fix #40, fix #41)

kert closed this issue

2026-03-13 14:37:40 +00:00

Sign in to join this conversation.