Fix deploy.yml: skipped path-filtered steps break depends_on chain #37

New Issue

kert · 2026-03-13T14:33:45Z

kert commented

2026-03-13 14:33:45 +00:00

Problem

The deploy step depends unconditionally on push-notebooks, push-zotero, upload-notebooks-scan, and upload-zotero-scan, all of which have when: path: filters. When those steps are skipped (most commits), the deploy step errors with step 'deploy' depends on unknown step 'push-notebooks'.

This means no pipeline runs at all — Woodpecker validates all .woodpecker/*.yml files together and aborts if any has unresolvable dependencies.

Fix

Remove when: path: filters from deploy.yml entirely. This pipeline only fires on push to main, so rebuilding all images unconditionally is the safe choice — it costs ~2 minutes extra but guarantees consistency. Path filters belong in ci.yml/infra-ci.yml for fast PR feedback.

Acceptance criteria

Push a commit touching only src/ files → deploy pipeline runs all steps through to provision
Push a commit touching notebooks/ files → notebooks image is built and deployed

## Problem The `deploy` step depends unconditionally on `push-notebooks`, `push-zotero`, `upload-notebooks-scan`, and `upload-zotero-scan`, all of which have `when: path:` filters. When those steps are skipped (most commits), the deploy step errors with `step 'deploy' depends on unknown step 'push-notebooks'`. This means **no pipeline runs at all** — Woodpecker validates all `.woodpecker/*.yml` files together and aborts if any has unresolvable dependencies. ## Fix Remove `when: path:` filters from deploy.yml entirely. This pipeline only fires on push to main, so rebuilding all images unconditionally is the safe choice — it costs ~2 minutes extra but guarantees consistency. Path filters belong in ci.yml/infra-ci.yml for fast PR feedback. ## Acceptance criteria - Push a commit touching only `src/` files → deploy pipeline runs all steps through to `provision` - Push a commit touching `notebooks/` files → notebooks image is built and deployed

kert added this to the P9: CI/CD Unification milestone 2026-03-13 14:33:45 +00:00

kert added the quality label 2026-03-13 14:33:45 +00:00

kert referenced this issue from a commit

2026-03-13 14:37:40 +00:00

P9 CI/CD unification: fix broken pipelines, harden deploy (fix #36, fix #37, fix #38, fix #39, fix #40, fix #41)

kert closed this issue

2026-03-13 14:37:40 +00:00

Sign in to join this conversation.