homelab/stack
1
0
Fork 0
Code Issues 247 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

bcda: adopt only jobs whose files are still served; survive a cancelled-while-adopting job #1296

New Issue
Closed
opened 2026-10-25 20:36:16 +00:00 by kert · 1 comment
kert commented 2026-10-25 20:36:16 +00:00
Owner
Copy Link

Upstream review docs/superpowers/specs/2026-10-25-bcda-upstream-review.md §D. completed_jobs() keeps every Task with FHIR status completed, which includes Archived/Expired jobs whose files are gone (410); since bcda-app #1495 a Completed job can be DELETEd by any sandbox user and turns Cancelled (404) mid-download.

  • filter completed_jobs() to end within 24 h (server file retention)
  • Store.adopt: finish as failed with the server diagnostics, keeping the files already downloaded, instead of raising mid-way
  • Exports page: hide/flag jobs older than 24 h
Upstream review docs/superpowers/specs/2026-10-25-bcda-upstream-review.md §D. `completed_jobs()` keeps every Task with FHIR status `completed`, which includes Archived/Expired jobs whose files are gone (410); since bcda-app #1495 a Completed job can be DELETEd by any sandbox user and turns Cancelled (404) mid-download. - [ ] filter `completed_jobs()` to `end` within 24 h (server file retention) - [ ] `Store.adopt`: finish as `failed` with the server diagnostics, keeping the files already downloaded, instead of raising mid-way - [ ] Exports page: hide/flag jobs older than 24 h
kert added this to the P52: BCDA v3 migration — client, crosswalk-driven flatteners, vendored upstream fixtures, proving notebook milestone 2026-10-25 20:36:16 +00:00
kert added the cli label 2026-10-25 20:36:16 +00:00
kert commented 2026-10-25 21:11:48 +00:00
Author
Owner
Copy Link

Done in 2cc1300: Client.completed_jobs(max_age_hours=24) drops Archived/Expired jobs; downloads attempt every file and record failures per file (the files ledger keeps what landed; resume finishes the rest).

Done in 2cc1300: `Client.completed_jobs(max_age_hours=24)` drops Archived/Expired jobs; downloads attempt every file and record failures per file (the files ledger keeps what landed; `resume` finishes the rest).
kert closed this issue 2026-10-25 21:11:48 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
REST API (FastAPI)
 auth
Authentication and authorization
 bib
Bibliography, Zotero, citations
 ci
CI/CD pipelines and Woodpecker plugins
 cli
CLI commands and UX
 cloud
Cloud provider abstraction (AWS, GCP, Azure, self-hosted)
 config
Configuration and wiring
 data
Data loading, CCLF, BCDA, seeds
 databricks
Databricks jobs and deployment
 docs
Documentation and generated references
 image:api
image:docs
image:mc
image:notebooks
image:zotero
infra
lakehouse
Nessie, Polaris, Trino, Iceberg
 llm
llm module — local RAG over comments + Zotero corpus
 notebooks
marimo notebook errors (auto-filed by nb-watcher/nb-integration)
 packaging
Python packaging, optional deps, build system
 pfs
pipeline
Pipeline execution and validation
 pipeline:ci
pipeline:deploy
pipeline:harden
pipeline:infra-ci
pipeline:rebuild-all
pipeline:release
qpp
quality
Testing, coverage, error handling
 step:build
step:deploy
step:hadolint
step:lint
step:publish
step:scan
step:test
step:validate
styles
Charts, figures, visual theming
 tree
Project directory structure and file organization
No Label cli
Milestone
No items
No Milestone P52: BCDA v3 migration — client, crosswalk-driven flatteners, vendored upstream fixtures, proving notebook
Projects
Clear projects
No project
Assignees
Clear assignees
kert renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: homelab/stack#1296
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?