homelab/stack
1
0
Fork 0
Code Issues 133 Pull Requests 1 Actions Packages Projects 1 Releases Wiki Activity

[P17] Add --close mode to api.diag.vuln for auto-closing resolved vulns #128

New Issue
Closed
opened 2026-03-23 18:11:15 +00:00 by kert · 0 comments
kert commented 2026-03-23 18:11:15 +00:00
Owner
Copy Link

Problem

Vuln issues (#114-#117) are created automatically but never closed. After hardening, a clean scan should auto-close the matching issue.

Fix

Add --close flag to api.diag.vuln:

uv run python -m api.diag.vuln --close notebooks-scan.json

Behavior:

  • Parse scan JSON
  • If no fixable HIGH/CRITICAL: find open issue with vuln: <image> title, close it with comment
  • If vulns remain: update existing issue or create new one

Acceptance criteria

  • --close mode implemented
  • Closes matching issue via Gitea API
  • Adds closing comment with scan summary
  • Full test coverage
## Problem Vuln issues (#114-#117) are created automatically but never closed. After hardening, a clean scan should auto-close the matching issue. ## Fix Add `--close` flag to `api.diag.vuln`: ```bash uv run python -m api.diag.vuln --close notebooks-scan.json ``` Behavior: - Parse scan JSON - If no fixable HIGH/CRITICAL: find open issue with `vuln: <image>` title, close it with comment - If vulns remain: update existing issue or create new one ## Acceptance criteria - [ ] `--close` mode implemented - [ ] Closes matching issue via Gitea API - [ ] Adds closing comment with scan summary - [ ] Full test coverage
kert added this to the P17: Hardened Containers — auto-patch vulns via CI/CD milestone 2026-03-23 18:11:15 +00:00
kert added the qualityci labels 2026-03-23 18:11:15 +00:00
kert closed this issue 2026-03-23 18:21:26 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
REST API (FastAPI)
 auth
Authentication and authorization
 bib
Bibliography, Zotero, citations
 ci
CI/CD pipelines and Woodpecker plugins
 cli
CLI commands and UX
 cloud
Cloud provider abstraction (AWS, GCP, Azure, self-hosted)
 config
Configuration and wiring
 data
Data loading, CCLF, BCDA, seeds
 databricks
Databricks jobs and deployment
 docs
Documentation and generated references
 image:api
image:docs
image:mc
image:notebooks
image:zotero
infra
lakehouse
Nessie, Polaris, Trino, Iceberg
 llm
llm module — local RAG over comments + Zotero corpus
 notebooks
marimo notebook errors (auto-filed by nb-watcher/nb-integration)
 packaging
Python packaging, optional deps, build system
 pfs
pipeline
Pipeline execution and validation
 pipeline:ci
pipeline:deploy
pipeline:harden
pipeline:infra-ci
pipeline:rebuild-all
pipeline:release
qpp
quality
Testing, coverage, error handling
 step:build
step:deploy
step:hadolint
step:lint
step:publish
step:scan
step:test
step:validate
styles
Charts, figures, visual theming
 tree
Project directory structure and file organization
No Label ci quality
Milestone
No items
No Milestone P17: Hardened Containers — auto-patch vulns via CI/CD
Projects
Clear projects
No project
Assignees
Clear assignees
dom kert renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: homelab/stack#128
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?