From d64c07f27187239be0233ec161f0d182b01f2ef4 Mon Sep 17 00:00:00 2001 From: kert Date: Thu, 29 Oct 2026 19:09:56 -0400 Subject: [PATCH] fix(ci): don't file failure issues for Renovate's branches MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A red renovate/* branch already stays unmerged and shows on Renovate's Dependency Dashboard; the auto-filer added an issue per failed job on top (ten from today's first Renovate batch, #1397–#1407). The failure step now skips branches named renovate/*, both as the push ref and as a PR head. Regenerated via gen_config.py; pkg-supply-chain.yml, which gen_config no longer emits, is edited the same way by hand. --- .gitea/workflows/bcda-vendor.yml | 2 +- .gitea/workflows/ci.yml | 4 ++-- .gitea/workflows/comment-pull.yml | 2 +- .gitea/workflows/deploy.yml | 14 +++++++------- .gitea/workflows/harden.yml | 2 +- .gitea/workflows/infra-ci.yml | 14 +++++++------- .gitea/workflows/llm-golden.yml | 2 +- .gitea/workflows/notebooks-integration.yml | 2 +- .gitea/workflows/pkg-supply-chain.yml | 2 +- .gitea/workflows/rebuild-all.yml | 2 +- .gitea/workflows/release.yml | 2 +- .gitea/workflows/zotero-sync.yml | 2 +- dev/scripts/backends/gitea.py | 8 ++++++-- 13 files changed, 31 insertions(+), 27 deletions(-) diff --git a/.gitea/workflows/bcda-vendor.yml b/.gitea/workflows/bcda-vendor.yml index 1f62a52..964dd70 100644 --- a/.gitea/workflows/bcda-vendor.yml +++ b/.gitea/workflows/bcda-vendor.yml @@ -27,7 +27,7 @@ jobs: run: uv run --no-project python dev/scripts/vendor_bcda_app.py --check - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | diff --git a/.gitea/workflows/ci.yml b/.gitea/workflows/ci.yml index 2b56870..aa95f7f 100644 --- a/.gitea/workflows/ci.yml +++ b/.gitea/workflows/ci.yml @@ -62,7 +62,7 @@ jobs: run: uv run pytest tests/ -x --cov=src --cov-report=term-missing --cov-fail-under=99 -q -n auto - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | @@ -109,7 +109,7 @@ jobs: run: uv run python dev/scripts/nb_integration.py --set ci-smoke - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | diff --git a/.gitea/workflows/comment-pull.yml b/.gitea/workflows/comment-pull.yml index f5fb6bb..70da2f7 100644 --- a/.gitea/workflows/comment-pull.yml +++ b/.gitea/workflows/comment-pull.yml @@ -34,7 +34,7 @@ jobs: docker exec llm uv run --no-sync stack llm index --collection comments - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | diff --git a/.gitea/workflows/deploy.yml b/.gitea/workflows/deploy.yml index c14d56f..85c84fd 100644 --- a/.gitea/workflows/deploy.yml +++ b/.gitea/workflows/deploy.yml @@ -134,7 +134,7 @@ jobs: crane push /tmp/notebooks.tar git:3000/homelab/stack/notebooks:latest --insecure - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | @@ -192,7 +192,7 @@ jobs: crane push /tmp/zotero.tar git:3000/homelab/stack/zotero:latest --insecure - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | @@ -250,7 +250,7 @@ jobs: crane push /tmp/docs.tar git:3000/homelab/stack/docs:latest --insecure - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | @@ -308,7 +308,7 @@ jobs: crane push /tmp/api.tar git:3000/homelab/stack/api:latest --insecure - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | @@ -366,7 +366,7 @@ jobs: crane push /tmp/bcda.tar git:3000/homelab/stack/bcda:latest --insecure - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | @@ -424,7 +424,7 @@ jobs: crane push /tmp/llm.tar git:3000/homelab/stack/llm:latest --insecure - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | @@ -482,7 +482,7 @@ jobs: crane push /tmp/mc.tar git:3000/homelab/stack/mc:latest --insecure - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | diff --git a/.gitea/workflows/harden.yml b/.gitea/workflows/harden.yml index 4dfe506..c4660d6 100644 --- a/.gitea/workflows/harden.yml +++ b/.gitea/workflows/harden.yml @@ -177,7 +177,7 @@ jobs: fi - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | diff --git a/.gitea/workflows/infra-ci.yml b/.gitea/workflows/infra-ci.yml index 7363a2a..02d5e7a 100644 --- a/.gitea/workflows/infra-ci.yml +++ b/.gitea/workflows/infra-ci.yml @@ -68,7 +68,7 @@ jobs: run: python3 dev/scripts/nb_fe_smoke.py --image local/notebooks:build --network ci - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | @@ -101,7 +101,7 @@ jobs: run: docker build -f infra/images/zotero.Dockerfile -t local/zotero:build . - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | @@ -134,7 +134,7 @@ jobs: run: docker build -f infra/images/docs.Dockerfile -t local/docs:build . - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | @@ -167,7 +167,7 @@ jobs: run: docker build -f infra/images/api.Dockerfile -t local/api:build . - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | @@ -200,7 +200,7 @@ jobs: run: docker build -f infra/images/bcda.Dockerfile -t local/bcda:build . - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | @@ -233,7 +233,7 @@ jobs: run: docker build -f infra/images/llm.Dockerfile -t local/llm:build . - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | @@ -266,7 +266,7 @@ jobs: run: docker build -f infra/images/mc.Dockerfile -t local/mc:build infra/rustfs/ - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | diff --git a/.gitea/workflows/llm-golden.yml b/.gitea/workflows/llm-golden.yml index 6d10662..235ecfd 100644 --- a/.gitea/workflows/llm-golden.yml +++ b/.gitea/workflows/llm-golden.yml @@ -50,7 +50,7 @@ jobs: exit "${golden_rc:-0}" - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | diff --git a/.gitea/workflows/notebooks-integration.yml b/.gitea/workflows/notebooks-integration.yml index 935eee6..8ce19ad 100644 --- a/.gitea/workflows/notebooks-integration.yml +++ b/.gitea/workflows/notebooks-integration.yml @@ -45,7 +45,7 @@ jobs: run: python3 dev/scripts/nb_fe_smoke.py --url http://notebooks:2718 --network gateway - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | diff --git a/.gitea/workflows/pkg-supply-chain.yml b/.gitea/workflows/pkg-supply-chain.yml index 8b055a3..d4ddfd8 100644 --- a/.gitea/workflows/pkg-supply-chain.yml +++ b/.gitea/workflows/pkg-supply-chain.yml @@ -61,7 +61,7 @@ jobs: run: uv run python dev/scripts/pkg_issues.py - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | diff --git a/.gitea/workflows/rebuild-all.yml b/.gitea/workflows/rebuild-all.yml index 19f4433..238f8e5 100644 --- a/.gitea/workflows/rebuild-all.yml +++ b/.gitea/workflows/rebuild-all.yml @@ -132,7 +132,7 @@ jobs: done - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | diff --git a/.gitea/workflows/release.yml b/.gitea/workflows/release.yml index 90e6ec1..4667fe8 100644 --- a/.gitea/workflows/release.yml +++ b/.gitea/workflows/release.yml @@ -30,7 +30,7 @@ jobs: dist/*.tar.gz - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | diff --git a/.gitea/workflows/zotero-sync.yml b/.gitea/workflows/zotero-sync.yml index 690ed2e..6c652ad 100644 --- a/.gitea/workflows/zotero-sync.yml +++ b/.gitea/workflows/zotero-sync.yml @@ -47,7 +47,7 @@ jobs: run: docker start zotero - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{ secrets.DEPLOY_TOKEN }} run: | diff --git a/dev/scripts/backends/gitea.py b/dev/scripts/backends/gitea.py index b8a2e31..2f2ae86 100644 --- a/dev/scripts/backends/gitea.py +++ b/dev/scripts/backends/gitea.py @@ -118,10 +118,14 @@ def _trivy_step( def _failure_step(workflow_name: str, job_name: str) -> str: - """Emit an if:failure() step that files a Gitea issue.""" + """Emit an if:failure() step that files a Gitea issue. + + Not for Renovate's branches: Renovate holds a red branch back and shows + it on its Dependency Dashboard, so an issue per failed job is noise. + """ return f"""\ - name: File failure issue - if: failure() + if: failure() && !startsWith(github.head_ref || github.ref_name, 'renovate/') env: GITEA_TOKEN: ${{{{ secrets.DEPLOY_TOKEN }}}} run: |